Add user block api call #4301
Open
Add user block api call #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmd-osm
reviewed
Oct 20, 2023
mmd-osm
reviewed
Oct 20, 2023
mmd-osm
reviewed
Oct 21, 2023
tomhughes
requested changes
Oct 21, 2023
AntonKhorev
force-pushed
the
blocks-api
branch
5 times, most recently
from
d1e66e6 to
f65029c
Compare
AntonKhorev
force-pushed
the
blocks-api
branch
from
f65029c to
9767fd9
Compare
AntonKhorev
force-pushed
the
blocks-api
branch
from
33c491d to
62db2c8
Compare
AntonKhorev
force-pushed
the
blocks-api
branch
2 times, most recently
from
083162b to
68ebbad
Compare
AntonKhorev
added
the
moderation
AntonKhorev
force-pushed
the
blocks-api
branch
from
26b6145 to
f09b537
Compare
AntonKhorev
force-pushed
the
blocks-api
branch
from
f09b537 to
0d891ae
Compare
|
Updated to align with #5155. |
AntonKhorev
force-pushed
the
blocks-api
branch
2 times, most recently
from
a7a96a1 to
da15d99
Compare
mmd-osm
reviewed
Oct 25, 2024
| raise OSM::APIBadUserInput, "No period was given" unless params[:period] | ||
|
|
||
| period = Integer(params[:period], :exception => false) | ||
| raise OSM::APIBadUserInput, "Period should be a number of hours" unless period |
There was a problem hiding this comment.
I'm wondering if the permitted values should be more in line with user_block_periods in settings.yml:
# Periods (in hours) which are allowed for user blocks
user_block_periods: [0, 1, 3, 6, 12, 24, 48, 96, 168, 336, 731, 4383, 8766, 87660]
Are values not explicitly mentioned there ok for the UI, or would they cause issues in dropdown lists?
There was a problem hiding this comment.
Block durations are not stored directly. Dropdowns show the closes value to the remaining time: #5011
AntonKhorev
force-pushed
the
blocks-api
branch
from
da15d99 to
8cfb274
Compare
AntonKhorev
force-pushed
the
blocks-api
branch
from
8cfb274 to
d4c88a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets block users by id, which helps in case they frequently change their username.