Queries and keys controllers in features namespace #5024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we every likely to have anything else in Also should it be singular |
AntonKhorev
force-pushed
the
feature-queries-controller
branch
from
b1ecf51 to
82efa48
Compare
AntonKhorev
force-pushed
the
feature-queries-controller
branch
from
82efa48 to
b2711a8
Compare
AntonKhorev
changed the title
AntonKhorev
force-pushed
the
feature-queries-controller
branch
from
b2711a8 to
3002807
Compare
AntonKhorev
changed the title
Moved map key there too. I thought about combining them into one toolbar button. When you click it, it shows map key. If you click on the map after that, it does a query. I haven't done this because it's possible to make queries work without an extra click, and then it's not clear how to get to the map key. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 2 of #4616.
BrowseControlleronly did feature queries. #4616 renamed it toQueriesControllerbut that wasn't entirely ok becouse it didn't tell what was queried.Here I'm renaming it to
Features::QueriesController.