Add 'canEmbed' layer option #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
map-layer-can-embed
branch
from
00c6c74 to
959a28a
Compare
|
This seems reasonable to me, but it's marked as a draft. Is there something else that needs working on first, or is it just the merge conflicts now? |
AntonKhorev
force-pushed
the
map-layer-can-embed
branch
from
959a28a to
8a8c251
Compare
|
There was something else, updated now. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check the added
canEmbedlayer option instead ofmap.getMapBaseLayerId() !== "tracestracktopo"when deciding whether Share > HTML should be available.