-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor social sharing helper #5417
Refactor social sharing helper #5417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works well on my side. Thank you.
This only happens on Mastodon Share links. Must be something related to their implementation. I'm not sure if the code is opensource since i could not find the github repo. On the web site about page there is only this information:
|
Looks like Request headers:
Response headers:
Then it's not related to this pull request, same happens in the already deployed version. |
5aa42bd
to
fcb2b44
Compare
Thanks for the refactoring! |
This implements the refactorings suggested in #5415 and also improves the testing of the generated HTML to ensure that all the buttons are generated and reference the correct URL and title.