Center share popup inside the browser window #5418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonKhorev
force-pushed
the
share-popup-center-window
branch
from
3fc487a to
2c57c66
Compare
|
It's definitely not centred for me: |
|
It works in Chromium so it must be a Firefox thing. This is definitely better when it works anyway, so thanks. |
|
Firefox is reporting the screen size as 1920x1080 which is half the real size of my display so it's only centring in the top left quadrant :-( I assume it's some hidpi scaling thing but I'm struggling to find any mention of it anywhere on the web. |
|
Though the screen height and width don't actually affect anything if they're larger than 640x480 so actually I don't understand this code at all. |
|
Screen size should be reported in css pixels according to MDN docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What the existing share popup window placement does is it places the popup horizontally in the center of the screen. I don't know if the popup can get placed literally in the corner (#5414 (comment)), maybe with a multi-monitor setup? But it still could be a surprising location if the monitor is large enough. Here the logic is changed to place the popup in the center of the browser window. Is it less surprising?
The only alternative to a popup window is a new tab, which is already available with middle click or context menu on share links.