Osdev 1376 closure report. updating auto email response to remove the word 'rejected' #462
Conversation
Updated text to remove the word "Rejected", added link to facility claim policy and clearer instruction to send a Reopen report.
Removed "Rejected", added link to policy, added instructions to submit reopening report.
Added closure report automated email update OSDEV-1376.
…il-response-to-remove-the-word-'rejected'
…il-response-to-remove-the-word-'rejected'
removed space under 'what's new' section
remove spacing
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
|
📝 WalkthroughWalkthroughThis pull request introduces version 1.27.0 of the Open Supply Hub project, focusing on improving user communication and fixing minor bugs. The changes primarily involve updating email templates for closure reports, enhancing the clarity of communication, and making minor improvements to API endpoints. Key modifications include refining email language, updating endpoint responses, and addressing date validation and sorting issues in the user interface and API. Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
src/django/api/templates/mail/report_result_body.txt (1)
6-6: Improve readability of conditional messagesThe conditional messages are hard to read due to lack of spacing. Consider adding line breaks between conditions for better maintainability.
-{% if is_closure and is_rejected %}We did not approve this report and the facility's profile in OS Hub has not been changed. For more details, view our Facility Closure Policy: https://info.opensupplyhub.org/governance-policies.{% endif %}{% if is_closure and is_confirmed %}The facility profile on OS Hub has now been updated and the facility is marked as closed.{% endif %}{% if is_reopening and is_rejected %}We did not approve this report and the facility's profile on OS Hub has not been changed.{% endif %}{% if is_reopening and is_confirmed %}The facility profile on OS Hub has now been updated and the facility is no longer marked as closed.{% endif %} +{% if is_closure and is_rejected %} +We did not approve this report and the facility's profile in OS Hub has not been changed. For more details, view our Facility Closure Policy: https://info.opensupplyhub.org/governance-policies. +{% endif %} +{% if is_closure and is_confirmed %} +The facility profile on OS Hub has now been updated and the facility is marked as closed. +{% endif %} +{% if is_reopening and is_rejected %} +We did not approve this report and the facility's profile on OS Hub has not been changed. +{% endif %} +{% if is_reopening and is_confirmed %} +The facility profile on OS Hub has now been updated and the facility is no longer marked as closed. +{% endif %}🧰 Tools
🪛 LanguageTool
[uncategorized] ~6-~6: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...y profile on OS Hub has now been updated and the facility is marked as closed.{% end...(COMMA_COMPOUND_SENTENCE_2)
[uncategorized] ~6-~6: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...y profile on OS Hub has now been updated and the facility is no longer marked as clo...(COMMA_COMPOUND_SENTENCE_2)
src/django/api/templates/mail/report_result_body.html (1)
14-17: Improve HTML structure for conditional messagesThe conditional messages could benefit from better HTML structure and spacing.
- {% if is_closure and is_rejected %}We did not approve this report and the facility's profile on OS Hub has not been changed. For more details, view our <a href="https://info.opensupplyhub.org/governance-policies">Facility Closure Policy</a>.{% endif %} - {% if is_closure and is_confirmed %}The facility profile on OS Hub has now been updated and the facility is marked as closed.{% endif %} - {% if is_reopening and is_rejected %}We did not approve this report and the facility's profile on OS Hub has not been changed.{% endif %} - {% if is_reopening and is_confirmed %}The facility profile on OS Hub has now been updated and the facility is no longer marked as closed.{% endif %} + {% if is_closure and is_rejected %} + <p>We did not approve this report and the facility's profile on OS Hub has not been changed. For more details, view our <a href="https://info.opensupplyhub.org/governance-policies">Facility Closure Policy</a>.</p> + {% endif %} + {% if is_closure and is_confirmed %} + <p>The facility profile on OS Hub has now been updated and the facility is marked as closed.</p> + {% endif %} + {% if is_reopening and is_rejected %} + <p>We did not approve this report and the facility's profile on OS Hub has not been changed.</p> + {% endif %} + {% if is_reopening and is_confirmed %} + <p>The facility profile on OS Hub has now been updated and the facility is no longer marked as closed.</p> + {% endif %}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
doc/release/RELEASE-NOTES.md(1 hunks)src/django/api/templates/mail/report_result_body.html(2 hunks)src/django/api/templates/mail/report_result_body.txt(1 hunks)
🧰 Additional context used
🪛 LanguageTool
src/django/api/templates/mail/report_result_body.txt
[uncategorized] ~6-~6: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...y profile on OS Hub has now been updated and the facility is marked as closed.{% end...
(COMMA_COMPOUND_SENTENCE_2)
[uncategorized] ~6-~6: Use a comma before “and” if it connects two independent clauses (unless they are closely connected and short).
Context: ...y profile on OS Hub has now been updated and the facility is no longer marked as clo...
(COMMA_COMPOUND_SENTENCE_2)
[typographical] ~10-~10: Do not use a colon (:) before a series that is introduced by a preposition (‘to’). Remove the colon or add a noun or a noun phrase after the preposition.
Context: ...|lower }}, email the relevant documents to: [email protected]{% endif %}{% if ...
(RP_COLON)
[misspelling] ~10-~10: Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’.
Context: ...re-opened in the future, please send us an report clicking the “Report” button (fl...
(EN_A_VS_AN)
🔇 Additional comments (4)
src/django/api/templates/mail/report_result_body.txt (2)
2-4: Verify the consistency of email greeting and introduction
The greeting and introduction are professional and clear. The addition of "on Open Supply Hub (OS Hub)" provides better context.
12-12: LGTM!
The closing signature is professional and consistent.
src/django/api/templates/mail/report_result_body.html (1)
13-14: Verify consistency with text template
The greeting and introduction match the text template, maintaining consistency across formats.
doc/release/RELEASE-NOTES.md (1)
26-26: LGTM!
The release notes accurately describe the changes made to the automated emails for closure reports, including:
- Removal of the term "Rejected"
- Addition of link to Closure Policy
- Addition of instructions for submitting a Reopening Report
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
React App | Jest test suite - Code coverage reportTotal: 27.88%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Dedupe Hub App | Unittest test suite - Code coverage reportTotal: 56.14%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Contricleaner App | Unittest test suite - Code coverage reportTotal: 98.91%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
Countries App | Unittest test suite - Code coverage reportTotal: 100%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
roman-stolar
temporarily deployed
to
Quality Environment
GitHub Actions
Inactive
Django App | Unittest test suite - Code coverage reportTotal: 79.96%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
roman-stolar
deleted the
OSDEV-1376-Closure-Report-Updating-auto-email-response-to-remove-the-word-rejected
branch
Updated the automated email for closure reports (report_result( to remove the term "Rejected" for an improved user experience. Added link to Closure Report policy and instructions to submit a reopening report to provide users with more information on the process.