Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OSDEV-1196] Prevent ?sort_by=contributors_desc from being added to URLs except on /facilities page #476

Merged
merged 8 commits into from
Jan 16, 2025
Merged

[OSDEV-1196] Prevent ?sort_by=contributors_desc from being added to URLs except on /facilities page #476

merged 8 commits into from
Jan 16, 2025

Conversation

Innavin369
Copy link
Contributor

@Innavin369 Innavin369 commented Jan 3, 2025 •
edited
Loading

OSDEV-1196 Prevent ?sort_by=contributors_desc from being added to URLs except on /facilities page

  • clear URL search parameters if it's not /facilities,
  • set up default option for sort_by Select to contributors_desc,
  • set up the initial state for filter sort_by=''

The React component, which represents the selected item from the Sort_by dropdown, is not serializable because it carries references to their props, children, internal state, and other non-serializable properties. The Redux FAQ explicitly recommends against storing such components in the store. Applied changes in FiltersReducer.js have fixed the console error.

Screenshot 2025-01-03 at 15 59 46 Screenshot 2025-01-03 at 16 00 00 Screenshot 2025-01-03 at 16 01 48

clear url if it's not /facilities, set up default option for sort by …
19e586a 
…contributors_desc, set up initial state for filter sort_by=''
@Innavin369 Innavin369 self-assigned this Jan 3, 2025
@Innavin369 Innavin369 marked this pull request as draft January 3, 2025 15:02
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:02 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:04 — with GitHub Actions Inactive
@barecheck barecheck
Copy link

barecheck bot commented Jan 3, 2025 •
edited
Loading

React App | Jest test suite - Code coverage report

Total: 28.31%

Your code coverage diff: -0.02% ▾

✅ All code changes are covered

@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 3, 2025 15:08 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 14, 2025 16:24 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 14, 2025 16:24 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 14, 2025 16:34 — with GitHub Actions Inactive
@VadimKovalenkoSNF
Copy link
Contributor

Approved.

VadimKovalenkoSNF
VadimKovalenkoSNF approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@VadimKovalenkoSNF VadimKovalenkoSNF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:36 — with GitHub Actions Inactive
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:38 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:42 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:43 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:43 — with GitHub Actions Inactive
@Innavin369 Innavin369 temporarily deployed to Quality Environment January 16, 2025 07:53 — with GitHub Actions Inactive
@Innavin369 Innavin369 merged commit 1c53d60 into main Jan 16, 2025
21 checks passed
@Innavin369 Innavin369 deleted the OSDEV-1196-remove-sort_by-from-url-where-it-necessary branch January 16, 2025 07:59
This was referenced Jan 17, 2025
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@VadimKovalenkoSNF VadimKovalenkoSNF VadimKovalenkoSNF approved these changes

@vladsha-dev vladsha-dev vladsha-dev approved these changes

@mazursasha1990 mazursasha1990 Awaiting requested review from mazursasha1990

@roman-stolar roman-stolar Awaiting requested review from roman-stolar

Assignees

@Innavin369 Innavin369

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Innavin369 @VadimKovalenkoSNF @vladsha-dev