Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add Finngen mappings version as a parameter to the disease LUT script #24

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ireneisdoomed
Copy link
Contributor

Finngen data is updated every so often to include new traits of study which we have to track.
The Finngen studies in the disease LUT was out of sync with the study table (version 5 instead of 6).

This caused a downstream problem in the ETL, when both dependencies are joined to form the study index. All Finngen studies were lacking their respective EFO.

The new table is uploaded here gs://genetics-portal-dev-staging/v2d/220816/trait_efo.parquet

Same schema as the previous one, an increase of 149 new Finngen traits (total of 3011).

There are stydues with a null reported trait, but that doesn't affect any of the downstream pipelines, since this field is not used.

In [4]: lut.count()
Out[4]: 56466

In [5]: lut.filter(F.col('trait_reported').isNull()).count()
Out[5]: 2352
```

…cript

Finngen data is updated every so often to include new traits of study which we have to track.
The instance name has been changed (the character `_` is not accepted). The conda installation instructions have been updated.
The `phenostring` column was misreferenced, causing the script to crash.
…ged`

The top loci and credible sets have been updated to take the outputs of the latest fine mapping run
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant