fix(isProteinCoding
): get all overlapping genes from the variant index
#948
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Context
This PR is related to the
isProteinCoding
L2G feature and these 2 issues:This PR largely solves an issue in the feature matrix where the protein coding annotation of the gene was wrongly attributed.
🛠 What does this PR implement
Reimplementation of
is_protein_coding_feature_logic
: instead of using the TSS location in the gene index to extract which gene the sentinel variant overlaps with, we now:Tests have been adjusted accordingly.
🙈 Missing
This solution is still not ideal as we still might be missing credible set/gene annotation for genes that are outside of the defined window. In that case we could still be wrongly annotating genes as non protein coding.
🚦 Before submitting
dev
branch?make test
)?poetry run pre-commit run --all-files
)?