Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating info in finngen study index ingestion #972

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

Daniel-Considine
Copy link
Contributor

@Daniel-Considine Daniel-Considine commented Jan 14, 2025

✨ Context

FinnGen R12 has 500,348 participants (282,064 females and 218,284 males). This PR updates the initialSampleSize column in the StudyIndex.

πŸ›  What does this PR implement

πŸ™ˆ Missing

🚦 Before submitting

  • Do these changes cover one single feature (one change at a time)?
  • Did you read the contributor guideline?
  • Did you make sure to update the documentation with your changes?
  • Did you make sure there is no commented out code in this PR?
  • Did you follow conventional commits standards in PR title and commit messages?
  • Did you make sure the branch is up-to-date with the dev branch?
  • Did you write any new necessary tests?
  • Did you make sure the changes pass local tests (make test)?
  • Did you make sure the changes pass pre-commit rules (e.g poetry run pre-commit run --all-files)?

@project-defiant
Copy link
Contributor

@Daniel-Considine Approved, but reflecting at this, having this stat hardcoded is not so good, since it always references r12 release.

@Daniel-Considine
Copy link
Contributor Author

@Daniel-Considine Approved, but reflecting at this, having this stat hardcoded is not so good, since it always references r12 release.

@project-defiant I agree, but R12 is meant to be the last FinnGen release, so it shouldn't be a problem in the future.

@Daniel-Considine Daniel-Considine merged commit 1475f7e into dev Jan 15, 2025
5 checks passed
@Daniel-Considine Daniel-Considine deleted the dc_finngen_r12 branch January 15, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Datasource size-XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants