Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional cryptoService param to TDF constructor #208

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Add optional cryptoService param to TDF constructor #208

merged 4 commits into from
Jul 12, 2023

Conversation

danielRicaud
Copy link
Contributor

No description provided.

@danielRicaud danielRicaud requested a review from a team as a code owner July 12, 2023 14:26
@danielRicaud danielRicaud self-assigned this Jul 12, 2023
dmihalcik-virtru
dmihalcik-virtru requested changes Jul 12, 2023
View reviewed changes
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you wire this through the create static method as well

dmihalcik-virtru
dmihalcik-virtru requested changes Jul 12, 2023
View reviewed changes
lib/tdf3/src/tdf.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmihalcik-virtru dmihalcik-virtru self-requested a review July 12, 2023 16:31
@danielRicaud danielRicaud merged commit ca6b664 into main Jul 12, 2023
8 checks passed
@danielRicaud danielRicaud deleted the feature/add-cryptoService-param-for-fips-in-TDF-constructor branch July 12, 2023 16:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmihalcik-virtru dmihalcik-virtru dmihalcik-virtru approved these changes

Assignees

@danielRicaud danielRicaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielRicaud @dmihalcik-virtru