Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Assertion signing keys and verification #398

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

elizabethhealy
Copy link
Member

@elizabethhealy elizabethhealy commented Dec 9, 2024

Add option to the cli to pass in assertion verification keys, handles assertion signing keys passed in on encrypt

Copy link

github-actions bot commented Dec 9, 2024

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link

github-actions bot commented Dec 9, 2024

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link

github-actions bot commented Dec 9, 2024

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@elizabethhealy elizabethhealy changed the title feat(cli): Assertion signing keys and verification feat(cli): Assertion signing keys and verification (otdfctl) Dec 9, 2024
@elizabethhealy elizabethhealy changed the title feat(cli): Assertion signing keys and verification (otdfctl) feat(cli): Assertion signing keys and verification Dec 9, 2024
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

@elizabethhealy elizabethhealy marked this pull request as ready for review December 10, 2024 15:07
@elizabethhealy elizabethhealy requested a review from a team as a code owner December 10, 2024 15:07
Copy link
Member

@dmihalcik-virtru dmihalcik-virtru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling error, otherwise good

lib/tdf3/src/client/builders.ts Outdated Show resolved Hide resolved
cli/src/cli.ts Outdated Show resolved Hide resolved
Copy link

If these changes look good, signoff on them with:

git pull && git commit --amend --signoff && git push --force-with-lease origin

If they aren't any good, please remove them with:

git pull && git reset --hard HEAD~1 && git push --force-with-lease origin

Copy link

sonarcloud bot commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants