DCS Modules #97
DCS Modules #97
Conversation
|
recheck |
|
recheck |
1 similar comment
|
recheck |
![otc-zuul[bot]](https://avatars.githubusercontent.com/in/11628?s=60&v=4){kind=small}
|
Current status:
Most however is finished |
plugins/modules/dcs_instance_info.py
Outdated
| # The API doesn't support queries, but we want to be able to not only list but also look for params of a specific instance | ||
| # This part removes other instances from the data result so that only the one with the given params will be shown | ||
| i = 0 | ||
| while i < len(data): |
There was a problem hiding this comment.
not sure where it was, but same as I already wrote you: instead of putting everything and then removing from array process in the single loop:
for raw in __instances__:
if A and B and C:
data.append(raw)
That would be more clear and mostly more performant, since drop from list is an expensive operation
| def run(self): | ||
| data = [] | ||
|
|
||
| # for raw in self.conn.dcs.backups(self.params['id']): |
|
recheck |
|
@SebastianGode can you please solve merge conflict? |
|
@gtema done |
|
recheck |
|
|
||
|
|
||
| class DcsInstanceStatisticsInfoModule(OTCModule): | ||
| argument_spec = dict( |
There was a problem hiding this comment.
even we can't do this from API pov, but I would really want to see support for name_or_id here. If not set - return everything, otherwise check name_or_id against item.name and item.id
There was a problem hiding this comment.
I wrote a way to filter it
|
@gtema I've updated the filter algorithm, should be faster now. |
No description provided.