-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/batch set commit weights #2485
Open
camfairchild
wants to merge
19
commits into
staging
Choose a base branch
from
feat/batch-set-commit-weights
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
056fbed
add batch set weights async and sync; needs tests
camfairchild e9a78a9
add impl for batch commit weights; async and sync
camfairchild 9849b48
add methods to subtensor
camfairchild 0b3e0de
add e2e tests relying on subtensor feat branch
camfairchild f990cf0
add test helpers
camfairchild 5f9e9f3
fix e2e test for commit weights
camfairchild 900905c
fix batch set and commit weights methods
camfairchild f62ad1d
Merge branch 'staging' into feat/batch-set-commit-weights
camfairchild ffc9ef3
use optional = None instead of [] for ver_keys
camfairchild d525572
oops: undeclared var
camfairchild 23a4965
use torch legacy dec
camfairchild 2f068e3
rename uidss/weightss -> nested_*
camfairchild b93ecd8
typo
camfairchild 1b70ba1
Merge branch 'staging' into feat/batch-set-commit-weights
thewhaleking 0ca543d
chore: remove unused imports
camfairchild 70c7cd1
missed type ignore
camfairchild 93fb3c0
chore: ruff
camfairchild da354d1
Merge branch 'staging' into feat/batch-set-commit-weights
thewhaleking a1cf473
Merge branch 'staging' into feat/batch-set-commit-weights
thewhaleking File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this is what you want. Calling
list
on a nparray will create a list of np ints, rather than a list of ints. Usually you'd do this witharray.tolist()
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is taken from
commit_weights