-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncSubstrateInterface Overhaul (with Sync AsyncSubstrate) #2526
Draft
thewhaleking
wants to merge
61
commits into
staging
Choose a base branch
from
feat/thewhaleking/new-sync-substrate
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewhaleking
changed the title
[WIP] sync AsyncSubstrateInterface
Sync AsyncSubstrateInterface
Dec 10, 2024
thewhaleking
force-pushed
the
feat/thewhaleking/new-sync-substrate
branch
2 times, most recently
from
December 10, 2024 18:32
d81be92
to
a35276a
Compare
thewhaleking
commented
Dec 10, 2024
This was referenced Dec 10, 2024
thewhaleking
changed the title
Sync AsyncSubstrateInterface
AsyncSubstrateInterface Overhaul (with Sync AsyncSubstrate)
Dec 12, 2024
thewhaleking
force-pushed
the
feat/thewhaleking/new-sync-substrate
branch
3 times, most recently
from
December 16, 2024 17:49
e5c8451
to
8383fce
Compare
thewhaleking
force-pushed
the
feat/thewhaleking/new-sync-substrate
branch
2 times, most recently
from
December 16, 2024 23:01
914b86a
to
59778da
Compare
1 task
…om the substrate-interface with bt-decode
…param to AsyncSubtensor methods
…cesses the events anyway)
thewhaleking
force-pushed
the
feat/thewhaleking/new-sync-substrate
branch
from
December 17, 2024 15:37
728754b
to
075f52a
Compare
thewhaleking
force-pushed
the
feat/thewhaleking/new-sync-substrate
branch
from
December 17, 2024 22:20
85cd1f1
to
fd0f2a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET. There's a handful of methods in py=substrate=itnerface that are not in this
Changes Subtensor (not AsyncSubtensor) to use AsyncSubstrateInterface through a wrapper. Adjusts the rest of Subtensor to handle this (including tests). Also improves the handling of reconnection in AsyncSubstrateInterface, which directly improves the sync version of it.
Removes all our
ensure_connected
wrappers, because we are now able to do the reconnection logic directly in the (Async)SubstrateInterfaceTODO: