Feat/use tx pool for set weights #2534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewhaleking
requested changes
Dec 17, 2024
thewhaleking
requested changes
Dec 17, 2024
thewhaleking
approved these changes
Dec 17, 2024
ibraheem-opentensor
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue with
set_weightscalls where submitting transactions can error if there is already aset_weightstransaction in the pool. This happens because the nonce and the call method match with a transaction already in the pool.We usually grab the next account nonce using the chain's state, and we increment it, therefore submitting the same nonce to the pool before the existing transaction has been included.
We can fix this by using the RPC method
account_nextIndexwhich takes into account all the transactions in the pool and gives you the next nonce that the account should use to not conflict with any pending transactions in the pool.