-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] Fix set children rate limit #1037
Conversation
🚨🚨🚨 HOTFIX DETECTED 🚨🚨🚨It looks like you are trying to merge a hotfix PR into . If this isn't what you wanted to do, and you just wanted to make a regular PR, please close this PR, base your changes off the branch and open a new PR into . If you are trying to merge a hotfix PR, please complete the following essential steps:
If you do not complete these steps, your hotfix may be inadvertently removed in the future when branches are promoted to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change breaks alot of the existing tests .
failures:
test_do_revoke_child_singular_success
test_do_revoke_children_multiple_complex_scenario
test_do_revoke_children_multiple_non_existent_children
test_do_revoke_children_multiple_partial_revocation
test_do_revoke_children_multiple_success
test_do_set_child_singular_multiple_children
test_do_set_child_singular_old_children_cleanup
test_do_set_child_singular_proportion_edge_cases
test_do_set_children_multiple_old_children_cleanup
test_do_set_children_multiple_overwrite_existing
can you please patch these ?
Should be fixed with new |
Description
This PR hotfixes the set_children rate limit of 2 tempos for a specific subnet.
Includes a test for the hotfix.
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly