Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate defaults for tx fee from min stake + tx validation #1183

Merged
merged 6 commits into from
Jan 24, 2025

Conversation

gztensor
Copy link
Contributor

@gztensor gztensor commented Jan 22, 2025

Description

  • Separate defaults for min stake and staking fee
  • Make min stake work like ED for stakes
  • Fix transaction validation for feeless staking transactions

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gztensor gztensor requested a review from unconst as a code owner January 22, 2025 21:01
@gztensor gztensor requested a review from camfairchild January 22, 2025 21:01
@gztensor gztensor changed the title Separate defaults for tx fee from min stake Separate defaults for tx fee from min stake + tx validation Jan 23, 2025
@gztensor gztensor requested a review from sam0x17 January 23, 2025 23:59
@gztensor gztensor added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jan 24, 2025
@sam0x17 sam0x17 merged commit 2977bdf into devnet-ready Jan 24, 2025
13 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants