Ban saturating_div, to_num, and from_num #1198
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove use of
saturating_div
,to_num
, andfrom_num
and replace with their safe (custom) versions:SafeDiv
trait,saturating_to_num
, andsaturating_from_num
respectively.Note for CI:
saturating_div
,to_num
, andfrom_num
should be forbidden (except in tests, tests should be able to panic).Type of Change
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly