-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Senate membership changes #490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
sam0x17
previously approved these changes
Jun 19, 2024
open-junius
reviewed
Jun 19, 2024
sam0x17
approved these changes
Jun 19, 2024
open-junius
approved these changes
Jun 20, 2024
distributedstatemachine
approved these changes
Jun 20, 2024
sam0x17
added
red team
feature development, etc
on-devnet
PR has been deployed to devnet
and removed
devnet-ready
PR's companion has been merged into devnet-ready
labels
Jun 21, 2024
distributedstatemachine
added
testnet-pass
PR was successfully tested on testnet
and removed
on-devnet
PR has been deployed to devnet
labels
Jul 2, 2024
sam0x17
approved these changes
Jul 3, 2024
clippy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devnet-pass
PR has been tested on devnet
red team
feature development, etc
testnet-pass
PR was successfully tested on testnet
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devnet companion: #557
Description
See related issue. This PR fixes a bug where current root members cannot become a Senate member after attaining the requirements after registering on the root network, initially.
This PR adds the call
subtensorModule.adjust_senate(hotkey)
to attempt to join the Senate when eligible.Related Issue(s)
Type of Change
TODO
Breaking Change
NA
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
NA
Additional Notes
An alternative solution is to call
join_senate_if_eligible
during aroot_register
call if the hotkey is already registered