Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delegate Id Coldkey Swap #706

Closed
wants to merge 6 commits into from
Closed

Conversation

JohnReedV
Copy link
Contributor

Description

Swap the coldkey for a delegate identity when a coldkey swap occurs.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@JohnReedV JohnReedV marked this pull request as ready for review August 1, 2024 02:34
@distributedstatemachine distributedstatemachine added the hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet label Aug 1, 2024
Copy link
Collaborator

@distributedstatemachine distributedstatemachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

pallets/subtensor/src/swap/swap_coldkey.rs Outdated Show resolved Hide resolved
pallets/subtensor/src/utils/identity.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@distributedstatemachine distributedstatemachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments . Also rerun benchmark to reflect additional cost for swapping identity

pallets/subtensor/tests/serving.rs Outdated Show resolved Hide resolved
@unconst unconst closed this Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devnet-companion hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants