-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subnet Identities #736
Merged
Merged
Subnet Identities #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-junius
reviewed
Aug 15, 2024
distributedstatemachine
approved these changes
Aug 23, 2024
distributedstatemachine
previously approved these changes
Aug 23, 2024
unconst
previously approved these changes
Aug 23, 2024
unconst
dismissed stale reviews from distributedstatemachine and themself
via
August 23, 2024 16:01
2c2a15d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds subnet Identities
Done:
set_subnet_identity
.SubnetInfo
.Todo:
Related Issue(s)
Type of Change
Breaking Change
user_add_network
now takes a second parameteridentity: Option<SubnetIdentityOf>
SubnetInfo
has a new parameteridentity: Option<SubnetIdentity>
.