add sudo call to set duration for schedule call #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
open-junius
requested review from
camfairchild,
JohnReedV,
distributedstatemachine and
sam0x17
sam0x17
previously approved these changes
Aug 20, 2024
sam0x17
previously approved these changes
Aug 20, 2024
sam0x17
previously approved these changes
Aug 21, 2024
distributedstatemachine
previously approved these changes
Aug 23, 2024
| @@ -992,9 +992,8 @@ impl<T: Config> Pallet<T> { | |||
| /// * 'SubNetworkDoesNotExist': If the specified network does not exist. | |||
| /// * 'NotSubnetOwner': If the caller does not own the specified subnet. | |||
| /// | |||
| pub fn user_remove_network(origin: T::RuntimeOrigin, netuid: u16) -> dispatch::DispatchResult { | |||
| pub fn user_remove_network(coldkey: T::AccountId, netuid: u16) -> dispatch::DispatchResult { | |||
| // --- 1. Ensure the function caller is a signed user. | |||
There was a problem hiding this comment.
fix comments
| @@ -1100,7 +1105,10 @@ mod dispatches { | |||
| let duration: BlockNumberFor<T> = DissolveNetworkScheduleDuration::<T>::get(); | |||
| let when: BlockNumberFor<T> = current_block.saturating_add(duration); | |||
|
|
|||
| let call = Call::<T>::dissolve_network { netuid }; | |||
| let call = Call::<T>::dissolve_network { | |||
There was a problem hiding this comment.
Do we need to check that the user owns the network they are trying to dissolve here ? From the looks of it , anyone can dissolve a network , so I think we should just check if the user is the owner of the network
There was a problem hiding this comment.
The owner could be updated after the call scheduled. You can check my test case. We could let the dissolve_network extrinsic to check when it is executed.
| @@ -681,7 +681,7 @@ mod dispatches { | |||
| new_coldkey: T::AccountId, | |||
| ) -> DispatchResultWithPostInfo { | |||
| // Ensure it's called with root privileges (scheduler has root privileges) | |||
| ensure_root(origin.clone())?; | |||
| ensure_root(origin)?; | |||
There was a problem hiding this comment.
nevermind , the check is the method
open-junius
dismissed stale reviews from distributedstatemachine and sam0x17
via
b4c1712
unconst
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.