-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reset neuron data on dereg #755
Merged
camfairchild
merged 1 commit into
opentensor:devnet-ready
from
backend-developers-ltd:fix-reg
Jan 27, 2025
Merged
reset neuron data on dereg #755
camfairchild
merged 1 commit into
opentensor:devnet-ready
from
backend-developers-ltd:fix-reg
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@andreea-popescu-reef also changed the base against |
bdd5e14
to
5e425fb
Compare
5e425fb
to
5e45f5c
Compare
5e45f5c
to
4b45cd3
Compare
e264672
to
fe5557a
Compare
rebased this pr |
ef3ce2d
to
a0f769a
Compare
camfairchild
previously approved these changes
Nov 26, 2024
roman-opentensor
previously approved these changes
Nov 26, 2024
4e51655
to
343cef2
Compare
rebased again |
camfairchild
approved these changes
Jan 20, 2025
343cef2
to
8642872
Compare
camfairchild
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
no-spec-version-bump
PR does not contain changes that requires bumping the spec version
skip-cargo-audit
This PR fails cargo audit but needs to be merged anyway
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reviving: #522
Description
On neuron registration the trust, emission, consensus, incentive, dividends values as well as axon info associated with the assigned neuron_uid are inherited from the previous neuron. Thus for the first few blocks after registration these values will be wrong, then reset to zero and then get populated with the correct values for the newly registered neuron. This change resets these values on neuron registration.