Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset neuron data on dereg #755

Merged

Conversation

andreea-popescu-reef
Copy link
Contributor

reviving: #522

Description

On neuron registration the trust, emission, consensus, incentive, dividends values as well as axon info associated with the assigned neuron_uid are inherited from the previous neuron. Thus for the first few blocks after registration these values will be wrong, then reset to zero and then get populated with the correct values for the newly registered neuron. This change resets these values on neuron registration.

@distributedstatemachine distributedstatemachine changed the base branch from main to devnet-ready August 27, 2024 12:55
@distributedstatemachine
Copy link
Collaborator

@andreea-popescu-reef also changed the base against devnet-ready , so you need to resolve conflicts , or fork off devnet-ready

@andreea-popescu-reef andreea-popescu-reef force-pushed the fix-reg branch 2 times, most recently from bdd5e14 to 5e425fb Compare August 31, 2024 08:54
@andreea-popescu-reef
Copy link
Contributor Author

rebased this pr

@andreea-popescu-reef andreea-popescu-reef force-pushed the fix-reg branch 2 times, most recently from ef3ce2d to a0f769a Compare November 15, 2024 13:54
runtime/src/lib.rs Outdated Show resolved Hide resolved
camfairchild
camfairchild previously approved these changes Nov 26, 2024
@andreea-popescu-reef
Copy link
Contributor Author

rebased again

@camfairchild camfairchild added no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Jan 27, 2025
@camfairchild camfairchild removed the request for review from roman-opentensor January 27, 2025 12:29
@camfairchild camfairchild merged commit 2ba69b1 into opentensor:devnet-ready Jan 27, 2025
3 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no-spec-version-bump PR does not contain changes that requires bumping the spec version skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants