Remove node requirement to build with runtime-benchmarks
#801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam0x17
approved these changes
Sep 11, 2024
orriin
added
the
no-spec-version-bump
unconst
approved these changes
Sep 12, 2024
distributedstatemachine
pushed a commit
that referenced
this pull request
Sep 23, 2024
Remove node requirement to build with `runtime-benchmarks`
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The genesis runtime was built with the
runtime-benchmarksfeature, making it expect the node to always expose benchmarking host functions even though they're never used.Even though the current runtime wasm is no longer built with
runtime-benchmarks, the node uses old wasm blobs during sync so it is necessary to keep them exposed.To solve this to date, we just have been always compiling with the
runtime-benchmarksfeature.This PR removes this feature requirement by including benchmark host functions in regular builds.