-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix/Patch new tempo runtime upgrade #806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam0x17
approved these changes
Sep 12, 2024
* add impl * add tests * add impl * chore: clippy * oops fix test * bump spec * add test from PR #805 * Revert "bump spec" This reverts commit 00ad4bf. * chore: fmt * remove lastaddstakeincrease logic * fix comment command * coinbase test with no deltas * add tests * renumber and remove * fix for childkey set weights * fix test for last commit * clippy: allow manual inspect * chore: fmt * add shebang * chore: clippy * move assert up * move clippy allow to toml * add fuzzy assert * fix neg delta test * Fix tests with correct take percent * fix typo
camfairchild
force-pushed
the
hotfix/patch-new-tempo-upgrade
branch
from
September 12, 2024 21:16
cdf280b
to
b07fdbb
Compare
unconst
approved these changes
Sep 12, 2024
unconst
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a combo hotfix of #799 and #807 (previously: #805 and #800)
LastAddStakeIncrease
check with a Stake Delta metric1set_weights
call filter to support child keys2PendingdHotkeyEmission
3Type of Change
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.
Footnotes
Hotfix/only exclude add stake from emission no packing #807 (previously Hotfix/only exclude new add stake from emission #800) ↩
https://github.com/opentensor/subtensor/pull/807/files/e763c85578ab77fa4b3f18a80f98dac6002c8a23..e6266158fc284c6e7f54ebaf93786d224ff1fec0 ↩
Hotfix/pending hotkey emission on swap #799 ↩ ↩2
f2b367c ↩