Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/Patch new tempo runtime upgrade #806

Merged
merged 15 commits into from
Sep 12, 2024
Merged

Conversation

camfairchild
Copy link
Contributor

@camfairchild camfairchild commented Sep 11, 2024

Description

This is a combo hotfix of #799 and #807 (previously: #805 and #800)

  • Replaces LastAddStakeIncrease check with a Stake Delta metric1
  • Fixes set_weights call filter to support child keys2
  • Adds a migration for Validators that made a hotkey swap without swapping PendingdHotkeyEmission3
  • Fixes the above-mentioned hotkey (and coldkey) swap bug3
  • Maintains reorder mul/div #808 fix for delegate-emission calculation
  • Changes an action secret to a variable4

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

Footnotes

  1. Hotfix/only exclude add stake from emission no packing #807 (previously Hotfix/only exclude new add stake from emission #800)

  2. https://github.com/opentensor/subtensor/pull/807/files/e763c85578ab77fa4b3f18a80f98dac6002c8a23..e6266158fc284c6e7f54ebaf93786d224ff1fec0

  3. Hotfix/pending hotkey emission on swap #799 2

  4. f2b367c

@camfairchild camfairchild changed the title bump spec Hotfix/Patch new tempo runtime upgrade Sep 11, 2024
@camfairchild camfairchild marked this pull request as ready for review September 12, 2024 00:44
* add impl

* add tests

* add impl

* chore: clippy

* oops fix test

* bump spec

* add test from PR #805

* Revert "bump spec"

This reverts commit 00ad4bf.

* chore: fmt

* remove lastaddstakeincrease logic

* fix comment command

* coinbase test with no deltas

* add tests

* renumber and remove

* fix for childkey set weights

* fix test for last commit

* clippy: allow manual inspect

* chore: fmt

* add shebang

* chore: clippy

* move assert up

* move clippy allow to toml

* add fuzzy assert

* fix neg delta test

* Fix tests with correct take percent

* fix typo
@camfairchild camfairchild force-pushed the hotfix/patch-new-tempo-upgrade branch from cdf280b to b07fdbb Compare September 12, 2024 21:16
@camfairchild camfairchild mentioned this pull request Sep 12, 2024
13 tasks
@unconst unconst merged commit 4f3f151 into main Sep 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants