-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set miner/ validator cut percentage #960
Closed
mz-Datura
wants to merge
9
commits into
opentensor:devnet-ready
from
mz-Datura:mz/feat/miner_validator_cut
Closed
set miner/ validator cut percentage #960
mz-Datura
wants to merge
9
commits into
opentensor:devnet-ready
from
mz-Datura:mz/feat/miner_validator_cut
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mz-Datura
changed the title
Mz/feat/miner validator cut
set miner/ validator cut percentage
Nov 12, 2024
open this into devnet-ready @mz-Datura |
cuteolaf
suggested changes
Nov 12, 2024
What are the new storage items for? |
Could you add the required fields? |
name is correct, please don't change item name. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements subnet-specific cut distribution for RAO emissions.
Changes:
Localizes owner cut per subnet (netuid specific)
Implements RAO emission distribution between:
Miner cut
Validator cut
Burn cut
Ensures all cuts sum to 100% (u16::MAX) per subnet
Validation:
Added test cases to verify cut calculations
Ensures proper distribution across all subnets
Maintains total cut sum constraint (100%)
Technical Details:
Each subnet maintains independent cut values
Burn cut automatically adjusts to maintain 100% total
All arithmetic operations use safe math to prevent overflow
Testing:
Test cases verify:
Initial cut distribution
Cut modifications maintain 100% total
Subnet-specific cut independence
Proper error handling for invalid values
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.