Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for 1.3.1 in CI #75

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Build for 1.3.1 in CI #75

merged 1 commit into from
Jun 5, 2024

Conversation

sunytt
Copy link
Contributor

@sunytt sunytt commented Jun 4, 2024

This PR fixes 2 issues:

  1. Added DOCKER=1 for otbr bootstrap to skip installing resolvconf.
  2. Fix the expected submodule path 'openthread' not to be a symbolic link issue caused by make-firmware for nrf52840 creates a symbolic link for openthread submodule. This is not accepted by the git_archive_all tool.

It also adds CI for building 1.3.1 reference release.

@sunytt sunytt requested review from superwhd and sherysheng June 4, 2024 13:10
script/make-firmware.bash Outdated Show resolved Hide resolved
script/otbr-setup.bash Outdated Show resolved Hide resolved
script/otbr-setup.bash Outdated Show resolved Hide resolved
@sunytt sunytt force-pushed the build131 branch 2 times, most recently from 9da5275 to cc8c2ce Compare June 4, 2024 13:32
Added DOCKER=1 for otbr bootstrap to skip installing resolvconf.

Fix the `expected submodule path 'openthread' not to be a symbolic link` issue caused by make-firmware for nrf52840 creates a symbolic link for openthread submodule. This is not accepted by the git_archive_all tool.

It also adds CI for building 1.3.1 reference release.
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

@sherysheng sherysheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@sunytt sunytt requested a review from jwhui June 5, 2024 05:50
@jwhui jwhui merged commit 3121ed7 into openthread:main Jun 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants