Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ot-commissioner to latest for 1.4 reference builds #83

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

suveshpratapa
Copy link
Member

No description provided.

Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@superwhd
Copy link
Contributor

superwhd commented Aug 5, 2024

Please also update the changelog. Thanks!

@suveshpratapa suveshpratapa force-pushed the task/ot-commissioner-update branch from 9a819df to 9793f1b Compare August 5, 2024 14:02
@suveshpratapa
Copy link
Member Author

Please also update the changelog. Thanks!

Thank you, updated it!

@suveshpratapa
Copy link
Member Author

@jwhui Can we please get this PR merged? Thank you.

@jwhui
Copy link
Member

jwhui commented Aug 5, 2024

@jwhui Can we please get this PR merged? Thank you.

@suveshpratapa , can you help resolve conflicts?

@librasungirl
Copy link

librasungirl commented Aug 6, 2024

Suggest to update to the hash with openthread/ot-commissioner#292 already merged, ( nice to have openthread/ot-commissioner#293 which is close to merge), which supports secure session establishment without petition to meet ePSKc test plan's requirement

@librasungirl
Copy link

Suggest to update to the hash with openthread/ot-commissioner#292 already merged, ( nice to have openthread/ot-commissioner#293 which is close to merge), which supports secure session establishment without petition to meet ePSKc test plan's requirement

and maybe in this or separate PR, OpenThread repo needs update to have the mandatory changes openthread/openthread#10524 for cert requirements

@librasungirl
Copy link

librasungirl commented Aug 8, 2024

Suggest to update to the hash with openthread/ot-commissioner#292 already merged, ( nice to have openthread/ot-commissioner#293 which is close to merge), which supports secure session establishment without petition to meet ePSKc test plan's requirement

may update to the latest upstream with 639e627 which has the updated/new cli commands for epskc test @suveshpratapa

@suveshpratapa suveshpratapa force-pushed the task/ot-commissioner-update branch from 9793f1b to 1d32bc7 Compare August 8, 2024 12:31
@suveshpratapa
Copy link
Member Author

may update to the latest upstream with 639e627 which has the updated/new cli commands for epskc test @suveshpratapa

Thank you @librasungirl ... just made the change to update ot-commissioner to https://github.com/openthread/ot-commissioner/commits/639e627/

and maybe in this or separate PR, OpenThread repo needs update to have the mandatory changes openthread/openthread#10524 for cert requirements

We already pushed a change recently to ot-reference-release (#84) that updates the openthread commit to 5493815, which includes the change you're talking about: https://github.com/openthread/openthread/commits/5493815/

@suveshpratapa
Copy link
Member Author

@jwhui Can we get this merged? Thanks.

@jwhui jwhui merged commit 35ae387 into openthread:main Aug 13, 2024
2 checks passed
@suveshpratapa suveshpratapa deleted the task/ot-commissioner-update branch August 27, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants