-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodules 'ot-br-posix' and 'openthread' for OTBR PD REF support #94
Conversation
@@ -166,6 +167,7 @@ elif [ "${REFERENCE_RELEASE_TYPE?}" = "1.4" ]; then | |||
'BORDER_ROUTING=1' | |||
'NAT64=1' | |||
'DNS64=1' | |||
'DHCPV6_PD_REF=1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: @sunytt, Do you have any idea why we need to repeat OTBR features' config as part of LOCAL_OPTIONS
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the reason why these local options are repeated from the beginning, I think different platforms can share the same definition. Could be an improvement for future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Could you log this update in the CHANGLOG file? Thanks @yangsong-cnyn |
When ot and otbr submodules are updated, may also update the ot-nrf528xx to contain latest changes. |
* ot-br-posix 7f04c183b04dc490a40bf34f72be7a1b79fa1fbf * openthread deb35b0c257f6f530cf55c89546772ab867e8041 * ot-nrf528xx f485040d87aa42e834bb24b5bf8115679d972ccd
updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
@@ -166,6 +167,7 @@ elif [ "${REFERENCE_RELEASE_TYPE?}" = "1.4" ]; then | |||
'BORDER_ROUTING=1' | |||
'NAT64=1' | |||
'DNS64=1' | |||
'DHCPV6_PD_REF=1' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the reason why these local options are repeated from the beginning, I think different platforms can share the same definition. Could be an improvement for future.
turn on prefix delegation for 1.4