Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodules 'ot-br-posix' and 'openthread' for OTBR PD REF support #94

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

yangsong-cnyn
Copy link
Contributor

@yangsong-cnyn yangsong-cnyn commented Oct 18, 2024

  • ot-br-posix 7f04c183b04dc490a40bf34f72be7a1b79fa1fbf
  • openthread deb35b0c257f6f530cf55c89546772ab867e8041
  • ot-nrf528xx f485040d87aa42e834bb24b5bf8115679d972ccd

turn on prefix delegation for 1.4

@@ -166,6 +167,7 @@ elif [ "${REFERENCE_RELEASE_TYPE?}" = "1.4" ]; then
'BORDER_ROUTING=1'
'NAT64=1'
'DNS64=1'
'DHCPV6_PD_REF=1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: @sunytt, Do you have any idea why we need to repeat OTBR features' config as part of LOCAL_OPTIONS?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the reason why these local options are repeated from the beginning, I think different platforms can share the same definition. Could be an improvement for future.

Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sunytt
Copy link
Contributor

sunytt commented Oct 18, 2024

Could you log this update in the CHANGLOG file? Thanks @yangsong-cnyn

@sunytt
Copy link
Contributor

sunytt commented Oct 18, 2024

When ot and otbr submodules are updated, may also update the ot-nrf528xx to contain latest changes.

* ot-br-posix 7f04c183b04dc490a40bf34f72be7a1b79fa1fbf
* openthread deb35b0c257f6f530cf55c89546772ab867e8041
* ot-nrf528xx f485040d87aa42e834bb24b5bf8115679d972ccd
@yangsong-cnyn
Copy link
Contributor Author

Could you log this update in the CHANGLOG file? Thanks @yangsong-cnyn

updated

Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@@ -166,6 +167,7 @@ elif [ "${REFERENCE_RELEASE_TYPE?}" = "1.4" ]; then
'BORDER_ROUTING=1'
'NAT64=1'
'DNS64=1'
'DHCPV6_PD_REF=1'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the reason why these local options are repeated from the beginning, I think different platforms can share the same definition. Could be an improvement for future.

@yangsong-cnyn yangsong-cnyn requested a review from jwhui October 21, 2024 02:25
@jwhui jwhui merged commit dbba91b into openthread:main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants