fix: disable irrelevant informations (#2910)

The "PlayerBadge" was loading a lot of unnecessary information for all
players on the account. I moved the if statement up, ensuring that only
the preload and level are properly loaded, which are actually relevant
information.

If more information is identified that should be loaded in the preload,
we should move it to the loadPlayerFirst function.

src/game/game.cpp

@@ -988,7 +988,7 @@ std::shared_ptr<Player> Game::getPlayerByName(const std::string &s, bool allowOf
 			return nullptr;
 		}
 		std::shared_ptr<Player> tmpPlayer = std::make_shared<Player>(nullptr);
-		if (!IOLoginData::loadPlayerByName(tmpPlayer, s)) {
+		if (!IOLoginData::loadPlayerByName(tmpPlayer, s, allowOffline)) {
 			if (!isNewName) {
 				g_logger().error("Failed to load player {} from database", s);
 			} else {

src/io/iologindata.cpp

@@ -123,6 +123,10 @@ bool IOLoginData::loadPlayer(std::shared_ptr<Player> player, DBResult_ptr result
 		// Experience load
 		IOLoginDataLoad::loadPlayerExperience(player, result);
 
+		if (disableIrrelevantInfo) {
+			return true;
+		}
+
 		// Blessings load
 		IOLoginDataLoad::loadPlayerBlessings(player, result);
 
@@ -180,10 +184,6 @@ bool IOLoginData::loadPlayer(std::shared_ptr<Player> player, DBResult_ptr result
 		// Load instant spells list
 		IOLoginDataLoad::loadPlayerInstantSpellList(player, result);
 
-		if (disableIrrelevantInfo) {
-			return true;
-		}
-
 		// load forge history
 		IOLoginDataLoad::loadPlayerForgeHistory(player, result);