fix: only take screenshot when achievement is successfully added (#2819)

Updated the luaPlayerAddAchievement method to capture screenshots only upon successful achievement addition, enhancing the game's responsiveness and resource efficiency. Also standardized the capitalization in log messages for the "Title System" and introduced a new screenshot type, SCREENSHOT_TYPE_GIFTOFLIFE, to support a specific feature called "Gift of Life."

src/game/game.cpp

@@ -10591,7 +10591,7 @@ std::map<uint16_t, Achievement> Game::getAchievements() {
 
 void Game::logCyclopediaStats() {
 	g_logger().info("Loaded {} badges from Badge System", m_badges.size());
-	g_logger().info("Loaded {} titles from Title system", m_titles.size());
+	g_logger().info("Loaded {} titles from Title System", m_titles.size());
 }
 
 std::unordered_set<Badge> Game::getBadges() {

src/lua/functions/core/game/lua_enums.cpp

@@ -228,6 +228,7 @@ void LuaEnums::initOthersEnums(lua_State* L) {
 	registerEnum(L, SCREENSHOT_TYPE_PLAYERATTACKING);
 	registerEnum(L, SCREENSHOT_TYPE_TREASUREFOUND);
 	registerEnum(L, SCREENSHOT_TYPE_SKILLUP);
+	registerEnum(L, SCREENSHOT_TYPE_GIFTOFLIFE);
 }
 
 void LuaEnums::initAccountEnums(lua_State* L) {

src/lua/functions/creatures/player/player_functions.cpp

@@ -4224,8 +4224,12 @@ int PlayerFunctions::luaPlayerAddAchievement(lua_State* L) {
 		achievementId = g_game().getAchievementByName(getString(L, 2)).id;
 	}
 
-	player->sendTakeScreenshot(SCREENSHOT_TYPE_ACHIEVEMENT);
-	pushBoolean(L, player->achiev()->add(achievementId, getBoolean(L, 3, true)));
+	bool success = player->achiev()->add(achievementId, getBoolean(L, 3, true));
+	if (success) {
+		player->sendTakeScreenshot(SCREENSHOT_TYPE_ACHIEVEMENT);
+	}
+
+	pushBoolean(L, success);
 	return 1;
 }
 

src/utils/utils_definitions.hpp

@@ -736,5 +736,6 @@ enum Screenshot_t : uint8_t {
 	SCREENSHOT_TYPE_PLAYERKILL = 9,
 	SCREENSHOT_TYPE_PLAYERATTACKING = 10,
 	SCREENSHOT_TYPE_TREASUREFOUND = 11,
-	SCREENSHOT_TYPE_SKILLUP = 12
+	SCREENSHOT_TYPE_SKILLUP = 12,
+	SCREENSHOT_TYPE_GIFTOFLIFE = 13,
 };