fix: login into another accounts

[phacUFPE]

Description

Prevents the login to other account when injecting a new login.php.

Behaviour

Actual

Change you login.php to request the players from a static account id that is not your account and try login into the server, it should login in a character that does not belong to your account.

Expected

Change you login.php to request the players from a static account id that is not your account and try login into the server, it shouldn't login in a character that does not belong to your account.

Fixes #2847

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Change your login.php to list a static account id different of which you are logging in.
• Try login into a character using your account and it should not be able to.

Test Configuration:

• Server Version: 3.1.2 (latest)
• Client: 13.40
• Operating System: Windows

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[github-actions]

Qodana for C/C++

2 new problems were found

Inspection name	Severity	Problems
misra-cpp2008-5-3-1	🔶 Warning	1
function-cognitive-complexity	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions