improve: improvement in receiving the bytes used in modules #2870
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestyotbr
approved these changes
Sep 11, 2024
dudantas
reviewed
Sep 12, 2024
| g_logger().debug("Player '{}' sent unknown packet header: hex[{}], decimal[{}]", player->getName(), asUpperCaseString(hexString), recvbyte); | ||
| break; | ||
| // Modules system | ||
| if (!g_modules().executeOnRecvbyte(player->getID(), msg, recvbyte)) { |
There was a problem hiding this comment.
This check: recvbyte != 0xD3 is still necessary? Because this byte is checked in another place (in the outfit window)
There was a problem hiding this comment.
In "recvbyte != 0xD3" the byte is not sent to executeOnRecvbyte and within the "case" it will also not reach executeOnRecvbyt, only within parseSetOutfit, as it already is, so the change does not change the functioning of this part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The byte packets received that pass through the
parsePacketfunction are sent toparsePacketFromDispatcherandg_modules().executeOnRecvbyte, but will be used in only one option of the two mentioned.To solve it, just use 'g_modules().executeOnRecvbyte' only if the package is not in the
parsePacketFromDispatcheroptionsFixes #2493
How Has This Been Tested
Test Configuration:
Checklist