fix: task context is being sent empty #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use the pull request template and describe your changes. |
|
Does this pull somehow bring any optimization to addEvent? |
No, it only resolves some false positive errors. |
elsongabriel
approved these changes
Sep 2, 2024
dudantas
reviewed
Sep 6, 2024
Closed
5 tasks
phacUFPE
approved these changes
Sep 14, 2024
dudantas
approved these changes
Sep 24, 2024
PrimosOT
pushed a commit
to PrimosOT/canary
that referenced
this pull request
Sep 25, 2024
Solve the problem where the message "[Task::Task] is sent: the task context cannot be empty!" because 'DispatcherContext::addEvent' and 'DispatcherContext::tryAddEvent' methods are not receiving the "context" parameter.
s2leandro155
pushed a commit
to s2leandro155/rzyns
that referenced
this pull request
Sep 26, 2024
Solve the problem where the message "[Task::Task] is sent: the task context cannot be empty!" because 'DispatcherContext::addEvent' and 'DispatcherContext::tryAddEvent' methods are not receiving the "context" parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solve the problem where the message "[Task::Task] is sent: the task context cannot be empty!" because 'DispatcherContext::addEvent' and 'DispatcherContext::tryAddEvent' methods are not receiving the "context" parameter.
thank you @beats-dh
Behaviour
Actual
error on server log: "[Task::Task] is sent: the task context cannot be empty!"
Expected
don't give error
Fixes #2709
Test Configuration:
Checklist