Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gain xp rate display with xp boost actived #2875

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

luanluciano93
Copy link
Contributor

Description

This PR fixes the value shown on the xp gain rate display when the player has xp boost and an xp rate greater than 1.

Behaviour

If you change the rate to 10, and have the character's stamina bonus (x1.5), just buy an xp boost in the store, your xp gain rate shown will be 1575%, as the base will be 1000% + 50% of the stamina which will be 1500%, when using the boost it should add +50%, which would be 2250%.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Test Configuration:

  • Server Version: Canary Main
  • Client: 13.40
  • Operating System: Windows 11

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

Copy link
Contributor

@phacUFPE phacUFPE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add into this PR the low level xp rate display fix? It is the getGrindingXpBoost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants