fix: problem with stack of items on the podium after server save

[luanluciano93]

Description

• Don't let items move on top of podium items
• Removing the Player:executeRewardEvents function that is not being used

Fixes #2859

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Test Configuration:

• Server Version: Canary Main
• Client: 13.40
• Operating System: Wiundows 11

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• My changes generate no new warnings

[FelipePaluco]

LGTM

[phacUFPE]

Tested and working as expected.

[powrogames]

@phacUFPE Have you tested more house items on stack? We have encounter the same issue and podium is not the only case here, all hose items after save server change order.

[phacUFPE]

@phacUFPE Have you tested more house items on stack? We have encounter the same issue and podium is not the only case here, all hose items after save server change order.

Could you provide the scenarios that the order is being messed up? You commented about other order issue but didn't provided the scenario, since you already have tested would be nice to give us the issue and save time with testing without having any clue of which items are still with order issues.

[powrogames]

@phacUFPE Have you tested more house items on stack? We have encounter the same issue and podium is not the only case here, all hose items after save server change order.

Could you provide the scenarios that the order is being messed up? You commented about other order issue but didn't provided the scenario, since you already have tested would be nice to give us the issue and save time with testing without having any clue of which items are still with order issues.

Sure, for example put item with id: 28944 and 31219. After SS they will be reordered

[lamonato29]

@phacUFPE Have you tested more house items on stack? We have encounter the same issue and podium is not the only case here, all hose items after save server change order.

Could you provide the scenarios that the order is being messed up? You commented about other order issue but didn't provided the scenario, since you already have tested would be nice to give us the issue and save time with testing without having any clue of which items are still with order issues.

Sure, for example put item with id: 28944 and 31219. After SS they will be reordered

In the file iomapserialize.cpp -> method IOMapSerialize::saveTile(PropWriteStream &stream, std::shared_ptr tile), change the lineitems.emplace_back(tub);to items.insert(items.begin(), tub);
and the line items.emplace_back(item); to items.insert(items.begin(), item);.
Please let me know if it solves the problem.

[Xalamander777]

@phacUFPE Have you tested more house items on stack? We have encounter the same issue and podium is not the only case here, all hose items after save server change order.

Could you provide the scenarios that the order is being messed up? You commented about other order issue but didn't provided the scenario, since you already have tested would be nice to give us the issue and save time with testing without having any clue of which items are still with order issues.

Sure, for example put item with id: 28944 and 31219. After SS they will be reordered

In the file iomapserialize.cpp -> method IOMapSerialize::saveTile(PropWriteStream &stream, std::shared_ptr tile), change the lineitems.emplace_back(tub);to items.insert(items.begin(), tub); and the line items.emplace_back(item); to items.insert(items.begin(), item);. Please let me know if it solves the problem.

Tested. It fixed in houses problem.
Thank you.