feat: new augments and update item description (amber items)

[phacUFPE]

Description

This PR updates the augments to be able to handle the substitution of the Increase Damage, Strong Impact and Powerful Impact into Base Damage and Base Healing. It also adds the new item description to handle the new Amber Items with elemental attack greater than 0 and physical attack value equal 0.

Behaviour

Actual

1. Try adding the value "base" as an augment and nothing should happen.
2. Try add the attack value to 0 and set some elemental damage, the atk with the elemental damage will not be displayed.

Expected

Do the same behavior as listed in the Actual section and it should all work.

Fixes #2895

Type of change

Please delete options that are not relevant.

• Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Add base value as an augment with the value of 100 and check if the value of a healing spell or attack spell doubles the attack or healing depending on the spell set in the augment
• Look into a weapon with the attack set as 0 or not set and an ice elemental attack set to 50, it should appear like "(Atk: 0 physical + 50 ice"
• Do the same as the previous test and check the item cyclopedia inspect and market details.

Test Configuration:

• Server Version: Latest (main)
• Client: 13.40
• Operating System: Windows

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works

[FelipePaluco]

LGTM

[github-actions]

Qodana for C/C++

1004 new problems were found

Inspection name	Severity	Problems
misra-cpp2008-5-0-11	🔶 Warning	889
err33-c	🔶 Warning	37
static-accessed-through-instance	🔶 Warning	16
misra-cpp2008-5-0-5	🔶 Warning	11
function-cognitive-complexity	🔶 Warning	7
misra-cpp2008-5-2-12	🔶 Warning	5
narrowing-conversions	🔶 Warning	3
unnecessary-value-param	🔶 Warning	3
implicit-bool-conversion	🔶 Warning	3
use-starts-ends-with	🔶 Warning	3
magic-numbers	🔶 Warning	3
misra-cpp2008-5-3-1	🔶 Warning	2
misra-cpp2008-5-0-13	🔶 Warning	2
misra-cpp2008-0-1-7	🔶 Warning	2
unnecessary-copy-initialization	🔶 Warning	2
for-range-copy	🔶 Warning	2
id-dependent-backward-branch	🔶 Warning	2
duplicate-include	🔶 Warning	2
simplify-boolean-expr	🔶 Warning	2
misra-cpp2008-6-4-5	🔶 Warning	1
misra-cpp2008-4-5-2	🔶 Warning	1
no-automatic-move	🔶 Warning	1
unroll-loops	🔶 Warning	1
too-small-loop-variable	🔶 Warning	1
pass-by-value	🔶 Warning	1
inconsistent-declaration-parameter-name	🔶 Warning	1
redundant-casting	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true

Contact Qodana team

Contact us at [email protected]

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[rokamdev]

Perfect! Everything working correctly!

[W4gNII]

good all work!