Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve readability and optimize toPosition function #2928

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omarcopires
Copy link
Contributor

@omarcopires omarcopires commented Sep 30, 2024

Description

This pull request refactors the string.toPosition function to improve readability and optimize the code. The main changes include:

  • Renaming variables to more descriptive names.
  • Optimized pattern matching by reusing patterns.
  • Returning nil when no pattern is matched, improving error handling.

These changes make the code clearer and more efficient without altering its functionality.

Fix

Interface: Scripts Interface
Script ID: E:\Repositorios Git\baiak-yurots\data/scripts\talkactions\gm\position.lua:callback
Error Description: ...it\baiak-yurots\data/scripts\talkactions\gm\position.lua:13: attempt to call method 'toPosition' (a nil value)
stack traceback:
        [C]: in function 'toPosition'
        ...it\baiak-yurots\data/scripts\talkactions\gm\position.lua:13: in function <...it\baiak-yurots\data/scripts\talkactions\gm\position.lua:3>

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

Copy link
Contributor

@QuebradaZN QuebradaZN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants