Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npc zoltan giving free ferumbras hat #2945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FelipePaluco
Copy link
Contributor

@FelipePaluco FelipePaluco commented Oct 4, 2024

Description

Change the NPC Zoltan to prevent exploits and having Ferumbras Hat for free.

Behaviour

Actual

Players can get Ferumbras Hat even not having Ferumbras Hat, additionally, wrong addon was being set to female characters.

Expected

Players can get Ferumbras Hat ONLY HAVING Ferumbras Hat.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Talk to NPC having Ferumbras Hat and get the mage male addon 2 or female summoner addon 2

Test Configuration:

  • Server Version: 13.40
  • Client: 13.40
  • Operating System: N/A

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@majestyotbr majestyotbr changed the title fix: fix wrongly giving ferumbras hat free fix: npc zoltan giving free ferumbras hat Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants