reviewdog [shellcheck] report
reported by reviewdog 🐶
Findings (5)
tests/build_and_run.sh|9 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
tests/build_and_run.sh|10 col 63| Quote this to prevent word splitting.
tests/build_and_run.sh|10 col 63| Use $(...) notation instead of legacy backticks ...
.
tests/build_and_run.sh|12 col 1| Use a ( subshell ) to avoid having to cd back.
tests/build_and_run.sh|13 col 1| Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Filtered Findings (3)
start_gdb.sh|18 col 6| Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
docker/config.sh|13 col 11| Use grep -q instead of comparing output with [ -n .. ].
recompile.sh|65 col 30| To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
Annotations
Check warning on line 9 in tests/build_and_run.sh
github-actions / shellcheck
[shellcheck] tests/build_and_run.sh#L9 <ShellCheck.SC2164>
Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Raw output
./tests/build_and_run.sh:9:1: warning: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (ShellCheck.SC2164)
Check warning on line 10 in tests/build_and_run.sh
github-actions / shellcheck
[shellcheck] tests/build_and_run.sh#L10 <ShellCheck.SC2046>
Quote this to prevent word splitting.
Raw output
./tests/build_and_run.sh:10:63: warning: Quote this to prevent word splitting. (ShellCheck.SC2046)
Check notice on line 10 in tests/build_and_run.sh
github-actions / shellcheck
[shellcheck] tests/build_and_run.sh#L10 <ShellCheck.SC2006>
Use $(...) notation instead of legacy backticks `...`.
Raw output
./tests/build_and_run.sh:10:63: info: Use $(...) notation instead of legacy backticks `...`. (ShellCheck.SC2006)
Check notice on line 12 in tests/build_and_run.sh
github-actions / shellcheck
[shellcheck] tests/build_and_run.sh#L12 <ShellCheck.SC2103>
Use a ( subshell ) to avoid having to cd back.
Raw output
./tests/build_and_run.sh:12:1: info: Use a ( subshell ) to avoid having to cd back. (ShellCheck.SC2103)
Check warning on line 13 in tests/build_and_run.sh
github-actions / shellcheck
[shellcheck] tests/build_and_run.sh#L13 <ShellCheck.SC2164>
Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
Raw output
./tests/build_and_run.sh:13:1: warning: Use 'cd ... || exit' or 'cd ... || return' in case cd fails. (ShellCheck.SC2164)