Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guild Wars #59

Open
1 task done
cys9211 opened this issue Jan 10, 2024 · 4 comments
Open
1 task done

Guild Wars #59

cys9211 opened this issue Jan 10, 2024 · 4 comments

Comments

@cys9211
Copy link

cys9211 commented Jan 10, 2024

Priority

High

Area

System

What OS are you seeing the problem on?

Windows

Browser

Chrome, Firefox, Edge, Opera, Safari, Other

What happened?

No possibility to declare war on the guild.
There are no buttons to control guild wars.

Code of Conduct

  • I agree to follow this project's Code of Conduct
Copy link

This issue is stale because it has been open 120 days with no activity.

@github-actions github-actions bot added the Stale label Apr 10, 2024
@tomasz1337
Copy link

bump

@github-actions github-actions bot removed the Stale label May 27, 2024
@ImConsKrypt
Copy link

ImConsKrypt commented Jun 18, 2024

EDIT
After I submitted this comment I discovered that there is more to get this to work and will update this once I have ironed out the issues most likely with a pull request.

EDIT 2
I have made progress and will submit a pull request - although my "fix" is not ideal but it's seemingly working as intended.
image
image
After kill;
image
image


In file guilds.view.html.twig located in /system/templates/ of your website edit the following;

AFTER line 133 add this;

                          <a href="?subtopic=guilds&guild={{ guild_name }}&action=guildwars_declare" style="padding:0px;margin:0px;">
                            {% set button_name = 'Declare War' %}
                            {% include('buttons.base.html.twig') %}
                          </a>
                          <div style="font-size:1px;height:4px;"></div>
                          <a href="?subtopic=guilds&guild={{ guild_name }}&action=guildwars"  style="padding:0px;margin:0px;">
                            {% set button_name = 'View Active Wars' %}
                            {% include('buttons.base.html.twig') %}
                          </a>
                          <div style="font-size:1px;height:4px;"></div>

You then should have access to declare war on another guild
image

You will also have to make some changes to guildwars.php which is located in /system/pages/guilds/
Line 64: (replace the entire line with below);

$wars_list = $db->query('SELECT `id`, `guild1`, `guild2`, `name1`, `name2`, `status`, `duration_days`, `frags`, `price1`, `price2` FROM `guild_wars`');

otherwise it will error out when you try to view the current war/accept a war request.

Copy link

This issue is stale because it has been open 120 days with no activity.

@github-actions github-actions bot added the Stale label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants