Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'FIX' for Guild War system with Canary #100

Closed
wants to merge 5 commits into from

Conversation

ImConsKrypt
Copy link

@ImConsKrypt ImConsKrypt commented Jun 19, 2024

Description

Although quite a sloppy "fix" it's somewhat working as intended,
Only submitting a pull request for those who want a quick "fix" for guild wars on Canary.

I know that I have not adhered to the current style guide nor have I added comments on my update. However, it does work as intended.

Behaviour

Actual

Enables Guild Wars to be set up and executed.

Expected

Guild War system via website.

Fixes #issuenumber

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested

Test Configuration:

  • MyAAC Version: (latest: 0.8.16)
  • Browser:
    • Chrome
    • Firefox
    • Opera
    • Safari
    • Edge
    • Other
  • Operating System:
    • Windows
    • Ubuntu
    • MacOS
    • Other

Checklist

  • I've created separated branch from main updated
  • My code follows the style guidelines of this project
  • I followed project rules, best practices, and code indentation
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@ImConsKrypt ImConsKrypt changed the title Im cons krypt patch 1 'FIX' for Guild War system with Canary Jun 19, 2024
Fixed a typo with War Rejection (wrong int defined for rejection)
@ImConsKrypt ImConsKrypt deleted the ImConsKrypt-patch-1 branch June 19, 2024 03:03
@ImConsKrypt ImConsKrypt restored the ImConsKrypt-patch-1 branch June 19, 2024 03:23
@ImConsKrypt ImConsKrypt reopened this Jun 19, 2024
@ImConsKrypt
Copy link
Author

Closing pull request as I discovered some issues that I did not test prior to submitting, will submit a new pull request once the issues are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guild Wars
1 participant