fix(toolbar): color and background color state #174

ZangHao0130 · 2024-12-27T07:18:52Z

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: #173

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

New Features
- Enhanced visual feedback for selected color options in the toolbar with a new indicator.
Bug Fixes
- Removed deprecated highlighting functionality for color panel items in dropdowns.

coderabbitai · 2024-12-27T07:19:00Z

Walkthrough

The pull request involves modifications to the styling of color picker and toolbar components in the Fluent Editor. The changes primarily focus on removing a specific mixin (pickerValue) from the common.scss file and updating the color selection visualization in the toolbar.scss file. The modifications aim to refine the visual representation of color selection and toolbar interactions.

Changes

File	Change Summary
`packages/fluent-editor/src/assets/common.scss`	Removed `@mixin pickerValue($group, $i)` mixin responsible for handling color panel item highlighting
`packages/fluent-editor/src/assets/toolbar.scss`	Updated `.ql-color` and `.ql-background` classes with new styling for selected picker items, adding a rotated 'L' character to indicate selection

Sequence Diagram

sequenceDiagram
    participant Toolbar
    participant ColorPicker
    participant SelectedItem
    
    Toolbar->>ColorPicker: Open color options
    ColorPicker-->>Toolbar: Display color items
    Toolbar->>SelectedItem: Select color
    SelectedItem->>SelectedItem: Apply selection style
    SelectedItem-->>Toolbar: Show 'L' indicator

Possibly related PRs

fix: toolbar style update and ts error #51: Changes to .ql-color and .ql-background classes in toolbar styling
fix: toolbar icon center #86: Enhancements to toolbar component styling and hover states
fix: move the styles inside the ql-toolbar to avoid style pollution #117: Modifications to interactive element visual feedback
fix: fix line-height invalid close #154 #155: Toolbar functionality improvements with line-height handling

Suggested labels

bug

Suggested reviewers

kagol

Poem

🐰 A Rabbit's Ode to Styling Flair

In SCSS we dance, with colors so bright
Mixins removed, selection takes flight
An 'L' appears, crisp and bold
Toolbar's story, now freshly told
Code refactored with rabbity care! 🎨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/fluent-editor/src/assets/toolbar.scss (1)

258-273: LGTM! Consider minor accessibility improvements.

The implementation effectively replaces the removed pickerValue mixin with a clean solution for indicating selected colors. The rotated 'L' approach is a common pattern in color pickers.

Consider these minor improvements:

 .ql-picker-options {
   .ql-picker-item {
     &.ql-selected {
       &::after {
         margin-left: 5px;
         margin-top: -3px;
         content: 'L';
         font-size: initial;
         font-family: arial;
+        /* Add fallback fonts for consistent rendering */
+        font-family: arial, sans-serif;
         -ms-transform: scaleX(-1) rotate(-45deg);
         -webkit-transform: scaleX(-1) rotate(-45deg);
         transform: scaleX(-1) rotate(-45deg);
+        /* Add transform-origin for consistent rotation */
+        transform-origin: center;
+        /* Add aria attributes for accessibility */
+        speak: none;
       }
     }
   }
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 24be218 and d81dc81.

📒 Files selected for processing (2)

packages/fluent-editor/src/assets/common.scss (0 hunks)
packages/fluent-editor/src/assets/toolbar.scss (1 hunks)

💤 Files with no reviewable changes (1)

packages/fluent-editor/src/assets/common.scss

kagol · 2025-01-02T01:33:13Z

@ZangHao0130 PR #184 is a better solution.

ZangHao0130 · 2025-01-03T02:05:16Z

@ZangHao0130 PR #184 is a better solution.

Do I think using the selected state maybe a better solution? The current implementation doesn't seem to consider extensibility, such as customizing the optional colors, and doesn't solve the real problem，eg:
const TOOLBAR_CONFIG = [ [{ color: ['#567890'] }, { background: [] }], ]

fix(toolbar): color and background color state

d81dc81

coderabbitai bot reviewed Dec 27, 2024

View reviewed changes

kagol closed this Jan 2, 2025

ZangHao0130 deleted the zane/fix-color-state branch January 2, 2025 05:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(toolbar): color and background color state #174

fix(toolbar): color and background color state #174

ZangHao0130 commented Dec 27, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 27, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

kagol commented Jan 2, 2025

ZangHao0130 commented Jan 3, 2025 •

edited

Loading

fix(toolbar): color and background color state #174

fix(toolbar): color and background color state #174

Conversation

ZangHao0130 commented Dec 27, 2024 • edited by coderabbitai bot Loading

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

coderabbitai bot commented Dec 27, 2024 • edited Loading

Walkthrough

Changes

Sequence Diagram

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

kagol commented Jan 2, 2025

ZangHao0130 commented Jan 3, 2025 • edited Loading

ZangHao0130 commented Dec 27, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 27, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

ZangHao0130 commented Jan 3, 2025 •

edited

Loading