Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: extract i18n to class module #176
refactor: extract i18n to class module #176
Changes from all commits
9f8fdba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zzxming 这两个变量为什么从 quill.options 移到了 quill 呢?直接放到 quill 中和放到 quill.options 中,一般如何选择呢?
另外是不是从 i18n 模块也能获取这两个变量,比如:this.quill.getModule('i18n').options.lang,这样是不是就重复了?
之前可能是没有抽取 i18n 模块,所以需要有一个地方承载 lang / langText,现在有 i18n 模块了,我觉得挂在 quill 的这两个变量是没有必要的。
不过这个不太要紧,我先合入,可以后续持续优化。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你说的有道理,这个是我在删依赖包的时候顺手改的,没注意太多。
但是我觉得在 this.quill 上挂
lang
这个变量还是有用的,i18n 是处理编辑器内文字的,有这个也可以更方便的获取当前编辑器的语,可以挂 getter,这样要修改还是要通过 changeLanguage 改,但是获取可以直接quill.lang
获取。langText
我可以抽离一个函数去获取对应文本,这样也不用每次获取文本都要写一长串了