Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve block property issue #971

Open
wants to merge 2 commits into
base: release/v2.1.0
Choose a base branch
from

Conversation

chilingling
Copy link
Member

@chilingling chilingling commented Dec 27, 2024

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

【问题描述】

  1. 新建区块。
  2. 拖入 Text 组件。
  3. Text 组件 文本内容属性创建并链接新属性。
  4. 打开区块管理面板,打开对应区块的设置。设置对应的属性
  5. 修改该关联属性的默认值,发现无法修改,报错:默认值语法解析错误

【问题分析】

关联的时候,关联物料的属性类型错误。物料类型为大写的 String,物料协议中是 string(全小写)

【解决方案】

修改内置物料的类型为全小写。

【其他改动】

  1. 显示值 label 改为属性名(ID)
  2. 描述 label 改为 属性显示名

原因:设置面板逻辑变动。显示 label 中的内容,而非显示默认的属性名。

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Updated user interface labels for property settings to improve clarity.
  • Bug Fixes

    • Standardized type definitions across various component schemas for consistency.

Copy link
Contributor

coderabbitai bot commented Dec 27, 2024

Walkthrough

The pull request introduces two main changes: first, a standardization of type definitions in the builtin.json schema by converting uppercase type names to lowercase (e.g., "String" to "string"), and second, a modification of labels in the BlockPropertyForm.vue component, updating the text for property-related form items. These changes aim to improve consistency in type definitions and refine the user interface text.

Changes

File Change Summary
packages/canvas/render/src/builtin/builtin.json Updated type definitions from uppercase to lowercase for Slot, Collection, Text, Icon, and Img components (e.g., "String""string", "Boolean""boolean")
packages/plugins/block/src/BlockPropertyForm.vue Modified form item labels:
- "显示值" changed to "属性名(ID)"
- "值类型" changed to "属性值类型"
- "描述" changed to "属性显示名"

Possibly related PRs

Suggested labels

refactor-main

Suggested reviewers

  • chilingling

Poem

🐰 Lowercase types hop and dance,
Schema's grammar takes a new stance!
Labels shift with gentle grace,
Consistency finds its rightful place
In code's delightful rabbit race! 🎉


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 16b51a2 and e5ed00f.

📒 Files selected for processing (1)
  • packages/plugins/block/src/BlockPropertyForm.vue (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/plugins/block/src/BlockPropertyForm.vue

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chilingling chilingling changed the title chore: update version to 2.1.0-rc.0 (#947) resolve block property issue Dec 27, 2024
@chilingling chilingling changed the title resolve block property issue fix: resolve block property issue Dec 27, 2024
@github-actions github-actions bot added the bug Something isn't working label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants