Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modal): the modal prompt box is compatible with the position of titles and content icons #1570

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

James-9696
Copy link
Collaborator

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@James-9696 James-9696 added the bug Something isn't working label Apr 16, 2024
@James-9696 James-9696 changed the title Fix modal problem fix: the modal prompt box is compatible with the position of titles and content icons Apr 16, 2024
@James-9696 James-9696 changed the title fix: the modal prompt box is compatible with the position of titles and content icons fix(modal): the modal prompt box is compatible with the position of titles and content icons Apr 17, 2024
@kagol kagol merged commit cb5e98b into opentiny:dev Apr 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants