fix(site): fix error when build saas site #2701
Conversation
WalkthroughThe pull request introduces modifications to theme management and import mapping across multiple files. The changes primarily focus on enhancing the SaaS theme configuration by adding a new Aurora theme, updating import paths, and making minor styling adjustments. The modifications span the playground application, layout component, and theme-related utility files, aiming to improve theme flexibility and import handling. Changes
Sequence DiagramsequenceDiagram
participant App as Playground App
participant ThemeTool as Theme Tool
participant AuroraTheme as Aurora Theme
participant OldTheme as Old Theme
App->>ThemeTool: Request theme change
ThemeTool->>AuroraTheme: Load Aurora theme
ThemeTool->>OldTheme: Load Old theme
ThemeTool-->>App: Apply selected theme
Possibly related PRs
Suggested Labels
Poem
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
[e2e-test-warn] The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug". Please make sure you've read our contributing guide |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/theme-saas/src/theme-tool.js (1)
2-2: Add usage notes regarding Aurora theme.The import statement for the new Aurora theme looks straightforward. However, ensure consumers of
tinyAuroraThemeclearly understand its purpose and how to integrate it into existing or new SaaS site builds. A short code comment or usage note would improve maintainability.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
examples/sites/playground/App.vue(1 hunks)examples/sites/src/views/layout/layout.vue(2 hunks)packages/theme-saas/src/aurora-theme-index.js(1 hunks)packages/theme-saas/src/old-theme-index.js(1 hunks)packages/theme-saas/src/theme-tool.js(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- packages/theme-saas/src/old-theme-index.js
- packages/theme-saas/src/aurora-theme-index.js
🔇 Additional comments (4)
packages/theme-saas/src/theme-tool.js (1)
4-4: Export consistency looks good.
Exporting both tinyOldTheme and tinyAuroraTheme in a single statement simplifies usage. This change aligns with the approach of making multiple themes readily accessible through a central interface.
examples/sites/src/views/layout/layout.vue (2)
264-272: Padding addition is consistent.
Introducing .tiny-tree-node__content-left with padding-left: 16px; refines the indentation and styling for the tree node text. This change enhances readability. Ensure it does not degrade small-screen layouts.
310-311: Minor coordinate adjustment.
The updated right: 8px; top: 13px; for .absolute-tag pinpoints the tag differently on the UI. Verify it aligns well across all supported screen sizes and doesn’t overlap other elements.
examples/sites/playground/App.vue (1)
92-93: Check for potential bundle-size increase.
Switching @opentiny/vue-common and @opentiny/vue references to the broader “all” or “saas” modules may load additional code not strictly needed in certain scenarios. Ensure this change is intentional and verify any impact on bundle size or build times.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
New Features
Bug Fixes
Documentation