-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.1.2 #263
Merged
Merged
v3.1.2 #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use .nvmrc (Node 16) and update some modules * Fix modules marked as critical vulnerabilities * Update a few more packages * Rev Node version to 18 (LTS) * Replace tslint (deprecated) with eslint * Rev version
* Note on full HD and scalable video * Set scalable video as default in sample app * README correction * adress PR comments * Typo correction --------- Co-authored-by: Ben <[email protected]>
Using npm audit fix
Update modules fix linting
Merged in from the master branch
Fix lint and build
* Remove unneeded logging * Fix linting errors * Add delay between network tests to wait for Sessions to disconnect * Rev version to 3.1.2 * Fix build (exclude test files)
vona-ben
approved these changes
Nov 30, 2023
marinaserranomontes
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Safari on iOS uses the latest webrtc-stats spec, which uses kind, not mediaType: https://www.w3.org/TR/webrtc-stats/. I am leaving the old `mediaType` property check in, in case some browsers use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update modules