-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added condition to stop and init capture #677
base: develop
Are you sure you want to change the base?
added condition to stop and init capture #677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @cnx-caiobarroso. Does it need to include changes to the files other than than those in OTScreenCapturer.java? Please remove the unneeded files from the PR.
@jeffswartz, done! |
The original issue clearly claims How does changing It seems unrelated imo |
@Panda-ref Hmm, I guess you are right, but I can't find this "Camera2VideoCapturer" file. Maybe it's related to the Gradle project, or as it uses the Android SDK under the covers it crashes there because of this error. |
Event with it potentially being unrelated, its still an improvement AFAIKT. |
Description
This PR prevents the startCapture and stopCapture functions from being called whenever the state isn't the opposite.
Contributing checklist
Solves issue(s)
#676