Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added condition to stop and init capture #677

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

cnx-caiobarroso
Copy link

@cnx-caiobarroso cnx-caiobarroso commented Jul 5, 2023

Description

This PR prevents the startCapture and stopCapture functions from being called whenever the state isn't the opposite.

Contributing checklist

  • [ x] Code must follow existing styling conventions
  • [ x] Added a descriptive commit message
  • [ x] Sample apps updated if needed

Solves issue(s)

#676

Copy link
Collaborator

@jeffswartz jeffswartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @cnx-caiobarroso. Does it need to include changes to the files other than than those in OTScreenCapturer.java? Please remove the unneeded files from the PR.

@cnx-caiobarroso
Copy link
Author

@jeffswartz, done!

@Panda-ref
Copy link

The original issue clearly claims
com.opentok.android.Camera2VideoCapturer.stopCapture crashing.

How does changing com.opentokreactnative.OTScreenCapturer.stopCapture/startCapture fix it?

It seems unrelated imo

@jeffswartz jeffswartz changed the base branch from main to develop August 24, 2023 16:50
@cnx-caiobarroso
Copy link
Author

cnx-caiobarroso commented Oct 26, 2023

@Panda-ref Hmm, I guess you are right, but I can't find this "Camera2VideoCapturer" file. Maybe it's related to the Gradle project, or as it uses the Android SDK under the covers it crashes there because of this error.

@pietgk
Copy link
Contributor

pietgk commented Nov 29, 2023

Event with it potentially being unrelated, its still an improvement AFAIKT.
So we could merge and finish this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants